Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[27.x backport] cli/command/container: use local copy of pkg/system.IsAbs #5699

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

thaJeztah
Copy link
Member

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 1eda498)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Dec 16, 2024
@thaJeztah thaJeztah added this to the 27.4.1 milestone Dec 16, 2024
@thaJeztah thaJeztah self-assigned this Dec 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.58%. Comparing base (70815c1) to head (d3b59fb).
Report is 7 commits behind head on 27.x.

Additional details and impacted files
@@           Coverage Diff           @@
##             27.x    #5699   +/-   ##
=======================================
  Coverage   58.58%   58.58%           
=======================================
  Files         346      346           
  Lines       29320    29322    +2     
=======================================
+ Hits        17176    17178    +2     
  Misses      11171    11171           
  Partials      973      973           

Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 4870b3d into docker:27.x Dec 16, 2024
99 checks passed
@thaJeztah thaJeztah deleted the 27.x_backport_remove_system_isabs branch December 16, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor PR's that refactor, or clean-up code status/2-code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants